ilgrosso commented on code in PR #444:
URL: https://github.com/apache/syncope/pull/444#discussion_r1172120610
##########
client/am/console/src/main/java/org/apache/syncope/client/console/panels/AttrRepoDirectoryPanel.java:
##########
@@ -18,17 +18,25 @@
*/
package org.apache.syncope.client.console.panels;
+import static org.apache.syncope.client.console.panels.DirectoryPanel.LOG;
Review Comment:
Please remove these static imports
##########
client/am/console/src/main/java/org/apache/syncope/client/console/panels/AuthModuleDirectoryPanel.java:
##########
@@ -18,17 +18,25 @@
*/
package org.apache.syncope.client.console.panels;
+import static org.apache.syncope.client.console.panels.DirectoryPanel.LOG;
Review Comment:
Please remove these static imports
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/clientapps/ClientAppDirectoryPanel.properties:
##########
@@ -65,3 +65,4 @@ privacyUrl=Privacy URL
compose.title=username attribute provider
usernameAttributeProviderConf.title=Username Attribute Provider for ${name}
ticketExpirationPolicy=Ticket Expiration Policy
+menu.history=Configuiration History
Review Comment:
Fix typo (all languages)
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/clientapps/ClientAppDirectoryPanel.properties:
##########
@@ -65,3 +65,4 @@ privacyUrl=Privacy URL
compose.title=username attribute provider
usernameAttributeProviderConf.title=Username Attribute Provider for ${name}
ticketExpirationPolicy=Ticket Expiration Policy
+menu.history=Configuiration History
Review Comment:
Also, copy the translation from other properties, to keep consistency, for
example `TopologyTogglePanel*.properties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
