ilgrosso commented on code in PR #535:
URL: https://github.com/apache/syncope/pull/535#discussion_r1371692654
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/OIDCScopeConstants.java:
##########
@@ -16,13 +16,28 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.syncope.common.lib.types;
+package org.apache.syncope.common.lib;
-public enum OIDCScope {
- openid,
- profile,
- email,
- address,
- phone
+import java.util.Arrays;
+import java.util.List;
+public final class OIDCScopeConstants {
+
+ public static final String OPEN_ID = "openid";
+
+ public static final String PROFILE = "profile";
+
+ public static final String EMAIL = "email";
+
+ public static final String ADDRESS = "address";
+
+ public static final String PHONE = "phone";
+
+ public static final String CUSTOM_SCOPE = "syncope";
+
+ public static final List<String> ALL_STANDARD_SCOPES =
Arrays.asList(OPEN_ID, PROFILE, EMAIL, ADDRESS, PHONE);
Review Comment:
Use `List.of()`
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/OIDCScopeConstants.java:
##########
@@ -16,13 +16,28 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.syncope.common.lib.types;
+package org.apache.syncope.common.lib;
-public enum OIDCScope {
- openid,
- profile,
- email,
- address,
- phone
+import java.util.Arrays;
+import java.util.List;
+public final class OIDCScopeConstants {
+
+ public static final String OPEN_ID = "openid";
+
+ public static final String PROFILE = "profile";
+
+ public static final String EMAIL = "email";
+
+ public static final String ADDRESS = "address";
+
+ public static final String PHONE = "phone";
+
+ public static final String CUSTOM_SCOPE = "syncope";
Review Comment:
Just name this `SYNCOPE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
