ilgrosso commented on code in PR #571:
URL: https://github.com/apache/syncope/pull/571#discussion_r1421416324
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LDAPMembershipPullActions.java:
##########
@@ -153,11 +154,8 @@ public void beforeUpdate(
}
groupDAO.findUMemberships(groupDAO.find(entity.getKey())).forEach(uMembership
-> {
- Set<String> memb =
membershipsBefore.get(uMembership.getLeftEnd().getKey());
- if (memb == null) {
- memb = new HashSet<>();
- membershipsBefore.put(uMembership.getLeftEnd().getKey(), memb);
- }
+ Set<String> memb =
membershipsBefore.computeIfAbsent(uMembership.getLeftEnd().getKey(),
Review Comment:
Not fundamental, but can you keep the same formatting as the other change
below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
