github-advanced-security[bot] commented on code in PR #702:
URL: https://github.com/apache/syncope/pull/702#discussion_r1587329153
##########
wa/starter/src/test/java/org/apache/syncope/wa/starter/AbstractTest.java:
##########
@@ -58,6 +80,136 @@
public SyncopeCoreTestingServer syncopeCoreTestingServer() {
return new SyncopeCoreTestingServer();
}
+
+ // This bean definition allows MacOS builds to complete successfully
+ @Bean(name = AttributeDefinitionStore.BEAN_NAME)
+ @RefreshScope(proxyMode = ScopedProxyMode.DEFAULT)
+ public AttributeDefinitionStore attributeDefinitionStore() {
+ return new AttributeDefinitionStore() {
+
+ @Override
+ public AttributeDefinitionStore
registerAttributeDefinition(final AttributeDefinition defn) {
+ return this;
+ }
+
+ @Override
+ public AttributeDefinitionStore registerAttributeDefinition(
+ final String key, final AttributeDefinition defn) {
+
+ return this;
+ }
+
+ @Override
+ public Optional<AttributeDefinition>
locateAttributeDefinitionByName(final String name) {
+ return Optional.empty();
+ }
+
+ @Override
+ public AttributeDefinitionStore
removeAttributeDefinition(final String key) {
+ return this;
+ }
+
+ @Override
+ public Optional<AttributeDefinition>
locateAttributeDefinition(final String key) {
+ return Optional.empty();
+ }
+
+ @Override
+ public <T extends AttributeDefinition> Optional<T>
locateAttributeDefinition(
+ final String key, final Class<T> clazz) {
+
+ return Optional.empty();
+ }
+
+ @Override
+ public <T extends AttributeDefinition> Optional<T>
locateAttributeDefinition(
+ final Predicate<AttributeDefinition> predicate) {
+
+ return Optional.empty();
+ }
+
+ @Override
+ public Collection<AttributeDefinition>
getAttributeDefinitions() {
+ return Set.of();
+ }
+
+ @Override
+ public <T extends AttributeDefinition> Stream<T>
getAttributeDefinitionsBy(final Class<T> type) {
+ return Stream.empty();
+ }
+
+ @Override
+ public Optional<Pair<AttributeDefinition, List<Object>>>
resolveAttributeValues(
+ final String key, final
AttributeDefinitionResolutionContext context) {
+
+ return Optional.empty();
+ }
+
+ @Override
+ public Map<String, List<Object>> resolveAttributeValues(
+ final Collection<String> attributeDefinitions,
+ final Map<String, List<Object>> availableAttributes,
+ final Principal principal,
+ final RegisteredService registeredService,
+ final Service service) {
+
+ return Map.of();
+ }
+
+ @Override
+ public boolean isEmpty() {
+ return true;
+ }
+
+ @Override
+ public AttributeDefinitionStore store(final Resource resource)
{
+ return this;
+ }
+
+ @Override
+ public AttributeDefinitionStore importStore(final
AttributeDefinitionStore definitionStore) {
+ return this;
+ }
+ };
+ }
+
+ @Bean(name = "aggregatingAttributeRepository")
+ @RefreshScope(proxyMode = ScopedProxyMode.DEFAULT)
+ public IPersonAttributeDao aggregatingAttributeRepository(
+ @Qualifier("attributeRepositoryAttributeMerger")
+ final IAttributeMerger attributeRepositoryAttributeMerger) {
Review Comment:
## Useless parameter
The parameter 'attributeRepositoryAttributeMerger' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1583)
##########
wa/starter/src/test/java/org/apache/syncope/wa/starter/AbstractTest.java:
##########
@@ -58,6 +80,136 @@
public SyncopeCoreTestingServer syncopeCoreTestingServer() {
return new SyncopeCoreTestingServer();
}
+
+ // This bean definition allows MacOS builds to complete successfully
+ @Bean(name = AttributeDefinitionStore.BEAN_NAME)
+ @RefreshScope(proxyMode = ScopedProxyMode.DEFAULT)
+ public AttributeDefinitionStore attributeDefinitionStore() {
+ return new AttributeDefinitionStore() {
+
+ @Override
+ public AttributeDefinitionStore
registerAttributeDefinition(final AttributeDefinition defn) {
+ return this;
+ }
+
+ @Override
+ public AttributeDefinitionStore registerAttributeDefinition(
+ final String key, final AttributeDefinition defn) {
+
+ return this;
+ }
+
+ @Override
+ public Optional<AttributeDefinition>
locateAttributeDefinitionByName(final String name) {
+ return Optional.empty();
+ }
+
+ @Override
+ public AttributeDefinitionStore
removeAttributeDefinition(final String key) {
+ return this;
+ }
+
+ @Override
+ public Optional<AttributeDefinition>
locateAttributeDefinition(final String key) {
+ return Optional.empty();
+ }
+
+ @Override
+ public <T extends AttributeDefinition> Optional<T>
locateAttributeDefinition(
+ final String key, final Class<T> clazz) {
+
+ return Optional.empty();
+ }
+
+ @Override
+ public <T extends AttributeDefinition> Optional<T>
locateAttributeDefinition(
+ final Predicate<AttributeDefinition> predicate) {
+
+ return Optional.empty();
+ }
+
+ @Override
+ public Collection<AttributeDefinition>
getAttributeDefinitions() {
+ return Set.of();
+ }
+
+ @Override
+ public <T extends AttributeDefinition> Stream<T>
getAttributeDefinitionsBy(final Class<T> type) {
+ return Stream.empty();
+ }
+
+ @Override
+ public Optional<Pair<AttributeDefinition, List<Object>>>
resolveAttributeValues(
+ final String key, final
AttributeDefinitionResolutionContext context) {
+
+ return Optional.empty();
+ }
+
+ @Override
+ public Map<String, List<Object>> resolveAttributeValues(
+ final Collection<String> attributeDefinitions,
+ final Map<String, List<Object>> availableAttributes,
+ final Principal principal,
+ final RegisteredService registeredService,
+ final Service service) {
+
+ return Map.of();
+ }
+
+ @Override
+ public boolean isEmpty() {
+ return true;
+ }
+
+ @Override
+ public AttributeDefinitionStore store(final Resource resource)
{
+ return this;
+ }
+
+ @Override
+ public AttributeDefinitionStore importStore(final
AttributeDefinitionStore definitionStore) {
+ return this;
+ }
+ };
+ }
+
+ @Bean(name = "aggregatingAttributeRepository")
+ @RefreshScope(proxyMode = ScopedProxyMode.DEFAULT)
+ public IPersonAttributeDao aggregatingAttributeRepository(
+ @Qualifier("attributeRepositoryAttributeMerger")
+ final IAttributeMerger attributeRepositoryAttributeMerger) {
+
+ return new IPersonAttributeDao() {
Review Comment:
## Inconsistent compareTo
This class declares [compareTo](1) but inherits equals; the two could be
inconsistent.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1584)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
