github-advanced-security[bot] commented on code in PR #915:
URL: https://github.com/apache/syncope/pull/915#discussion_r1890436197
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/ProvisioningProfile.java:
##########
@@ -55,35 +70,27 @@
return task;
}
- public List<ProvisioningReport> getResults() {
- return results;
- }
-
public boolean isDryRun() {
return dryRun;
}
- public void setDryRun(final boolean dryRun) {
- this.dryRun = dryRun;
- }
-
public ConflictResolutionAction getConflictResolutionAction() {
return conflictResolutionAction;
}
- public void setConflictResolutionAction(final ConflictResolutionAction
conflictResolutionAction) {
- this.conflictResolutionAction = conflictResolutionAction;
- }
-
public String getExecutor() {
return executor;
}
- public void setExecutor(final String executor) {
- this.executor = executor;
- }
-
public List<A> getActions() {
return actions;
}
+
+ public List<ProvisioningReport> getResults() {
Review Comment:
## Exposing internal representation
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](1).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](2).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](3).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](4).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](5).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](6).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](7).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](8).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](9).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](10).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](11).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](12).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](13).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](14).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](15).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](16).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](17).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](18).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](19).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](20).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](21).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](22).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](23).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](24).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](25).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](26).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](27).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](28).
getResults exposes the internal representation stored in field results. The
value may be modified [after this call to getResults](29).
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1749)
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/LiveSyncJob.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.core.provisioning.java.job;
+
+import java.util.Optional;
+import org.apache.syncope.common.lib.types.TaskType;
+import org.apache.syncope.core.persistence.api.entity.Implementation;
+import org.apache.syncope.core.provisioning.api.job.JobExecutionContext;
+import org.apache.syncope.core.provisioning.api.job.JobExecutionException;
+import org.apache.syncope.core.provisioning.api.job.JobManager;
+import org.apache.syncope.core.provisioning.java.pushpull.LiveSyncJobDelegate;
+import org.apache.syncope.core.spring.implementation.ImplementationManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class LiveSyncJob extends TaskJob {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(LiveSyncJob.class);
+
+ protected LiveSyncJobDelegate delegate;
Review Comment:
## Field masks field in super class
This field shadows another field called [delegate](1) in a superclass.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1750)
##########
common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/to/LiveSyncTaskTO.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.common.lib.to;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
+import io.swagger.v3.oas.annotations.media.Schema;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+
+@Schema(allOf = { InboundTaskTO.class })
+public class LiveSyncTaskTO extends InboundTaskTO implements TemplatableTO {
+
+ private static final long serialVersionUID = -2727384303923661649L;
+
+ private String liveSyncDeltaMapper;
+
+ private final Map<String, AnyTO> templates = new HashMap<>();
+
+ @JacksonXmlProperty(localName = "_class", isAttribute = true)
+ @JsonProperty("_class")
+ @Schema(name = "_class", requiredMode = Schema.RequiredMode.REQUIRED,
+ example = "org.apache.syncope.common.lib.to.LiveSyncTaskTO")
+ @Override
+ public String getDiscriminator() {
+ return getClass().getName();
+ }
+
+ public String getLiveSyncDeltaMapper() {
+ return liveSyncDeltaMapper;
+ }
+
+ public void setLiveSyncDeltaMapper(final String liveSyncDeltaMapper) {
+ this.liveSyncDeltaMapper = liveSyncDeltaMapper;
+ }
+
+ @Override
+ public Map<String, AnyTO> getTemplates() {
Review Comment:
## Exposing internal representation
getTemplates exposes the internal representation stored in field templates.
The value may be modified [after this call to getTemplates](1).
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1748)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
