ilgrosso commented on code in PR #1127:
URL: https://github.com/apache/syncope/pull/1127#discussion_r2184858405
##########
core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/repo/GroupRepoExt.java:
##########
@@ -50,6 +51,8 @@ public interface GroupRepoExt extends AnyRepoExt<Group> {
List<UMembership> findUMemberships(Group group);
Review Comment:
Remove this method (see above).
##########
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/GroupRepoExt.java:
##########
@@ -50,6 +51,8 @@ public interface GroupRepoExt extends AnyRepoExt<Group> {
List<UMembership> findUMemberships(Group group);
+ List<UMembership> findUMemberships(Group group, Pageable pageable);
Review Comment:
Please remove the existing method
```java
List<UMembership> findUMemberships(Group group);
```
and replace all existing invocations
```findUMembership(group)```
with
```findUMembership(group, Pageable.unpaged())```
Naturally, you will need to adjust the new code to handle the case when
`Pageable.unpaged()` is passed as an argument.
##########
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/GroupDAO.java:
##########
@@ -60,6 +61,8 @@ public interface GroupDAO extends AnyDAO<Group> {
List<UMembership> findUMemberships(Group group);
Review Comment:
Remove this method (see below).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
