ilgrosso commented on code in PR #1170:
URL: https://github.com/apache/syncope/pull/1170#discussion_r2324212780
##########
client/am/console/src/main/java/org/apache/syncope/client/console/panels/PasswordManagementDirectoryPanel.java:
##########
@@ -0,0 +1,249 @@
+package org.apache.syncope.client.console.panels;
Review Comment:
Missing license header
##########
client/am/console/src/main/java/org/apache/syncope/client/console/rest/PasswordManagementRestClient.java:
##########
@@ -0,0 +1,30 @@
+package org.apache.syncope.client.console.rest;
Review Comment:
Missing license header
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/panels/PasswordManagementDirectoryPanel.properties:
##########
@@ -0,0 +1,8 @@
+any.edit=Edit Parameter ${key}
+any.new=New Password Module
Review Comment:
Password "Module"??!? - fix in all related properties files
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/panels/PasswordManagementDirectoryPanel.properties:
##########
@@ -0,0 +1,8 @@
+any.edit=Edit Parameter ${key}
Review Comment:
Missing license header
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/wizards/PasswordManagementWizardBuilder$Profile.properties:
##########
@@ -0,0 +1,4 @@
+description=Description
Review Comment:
Missing license header
##########
client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/ActionLink.java:
##########
@@ -110,7 +110,8 @@ public enum ActionType {
EDIT_APPROVAL("edit"),
VIEW_AUDIT_HISTORY("read"),
EXTERNAL_EDITOR("externalEditor"),
- EXPLORE_RESOURCE("search");
+ EXPLORE_RESOURCE("search"),
+ ENABLE_PM("update");
Review Comment:
Can't you reuse one of existing actions here instead of adding a new one
that will be exclusively used by one panel??!
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/password/RESTPasswordManagementConf.java:
##########
@@ -0,0 +1,172 @@
+package org.apache.syncope.common.lib.password;
Review Comment:
Missing license header
##########
core/am/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/PasswordManagementServiceImpl.java:
##########
@@ -0,0 +1,47 @@
+package org.apache.syncope.core.rest.cxf.service;
Review Comment:
Missing license header
##########
core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/validation/PasswordManagementValidator.java:
##########
@@ -0,0 +1,30 @@
+package org.apache.syncope.core.persistence.common.validation;
Review Comment:
Missing license header
##########
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/PasswordManagementRepoExtImpl.java:
##########
@@ -0,0 +1,40 @@
+package org.apache.syncope.core.persistence.jpa.dao.repo;
Review Comment:
Missing license header
##########
core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/repo/PasswordManagementRepoExtImpl.java:
##########
@@ -0,0 +1,55 @@
+package org.apache.syncope.core.persistence.neo4j.dao.repo;
Review Comment:
Missing license header
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/PasswordManagementDataBinderImpl.java:
##########
@@ -0,0 +1,48 @@
+package org.apache.syncope.core.provisioning.java.data;
Review Comment:
Missing license header
##########
wa/starter/pom.xml:
##########
@@ -416,15 +438,15 @@ under the License.
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-actuator</artifactId>
+ <artifactId>spring-boot-starter-security</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-security</artifactId>
+ <artifactId>spring-boot-starter-validation</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-validation</artifactId>
+ <artifactId>spring-boot-starter-actuator</artifactId>
Review Comment:
revert this change
##########
wa/starter/pom.xml:
##########
@@ -161,6 +161,22 @@ under the License.
<groupId>org.apereo.cas</groupId>
<artifactId>cas-server-support-ldap</artifactId>
</dependency>
+ <dependency>
Review Comment:
`cas-server-support-jdbc` is already in this file, shall not be added.
Move those new `cas-server-support-pm-*` dependencies right after the newly
inserted `cas-server-support-pm-core` as they are related.
##########
client/am/console/src/main/java/org/apache/syncope/client/console/wizards/PasswordManagementWizardBuilder.java:
##########
@@ -0,0 +1,141 @@
+package org.apache.syncope.client.console.wizards;
Review Comment:
Missing license header
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/pages/WA_it.properties:
##########
@@ -16,6 +16,7 @@
# under the License.
wa=WA
authModules=Moduli di Autenticazione
+passwordManagements=Password Management
Review Comment:
This shall be "Gestione Password"
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/wizards/PasswordManagementWizardBuilder$Configuration.properties:
##########
@@ -0,0 +1,7 @@
+plainAttrs=Plain Attributes
Review Comment:
Why such labels?
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/wizards/PasswordManagementWizardBuilder$Profile_it.properties:
##########
@@ -0,0 +1,4 @@
+description=Descrizione
Review Comment:
Provide at least Italian translations
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/wizards/AuthModuleWizardBuilder$Profile.html:
##########
@@ -17,11 +17,12 @@
under the License.
-->
<html xmlns="http://www.w3.org/1999/xhtml";
xmlns:wicket="http://wicket.apache.org";>
- <wicket:panel>
+<wicket:panel>
Review Comment:
Revert formatting changes
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/wizards/PasswordManagementWizardBuilder$Profile.html:
##########
@@ -0,0 +1,8 @@
+<html xmlns="http://www.w3.org/1999/xhtml";
xmlns:wicket="http://wicket.apache.org";>
Review Comment:
Missing license header
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/password/JDBCPasswordManagementConf.java:
##########
@@ -0,0 +1,119 @@
+package org.apache.syncope.common.lib.password;
Review Comment:
Missing license header
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/password/PasswordManagementConf.java:
##########
@@ -0,0 +1,25 @@
+package org.apache.syncope.common.lib.password;
Review Comment:
Missing license header
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/to/PasswordManagementTO.java:
##########
@@ -0,0 +1,86 @@
+package org.apache.syncope.common.lib.to;
Review Comment:
Missing license header
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/wizards/PasswordManagementWizardBuilder$Configuration.html:
##########
@@ -0,0 +1,5 @@
+<html xmlns="http://www.w3.org/1999/xhtml";
xmlns:wicket="http://wicket.apache.org";>
Review Comment:
Missing license header
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/password/LDAPPasswordManagementConf.java:
##########
@@ -0,0 +1,28 @@
+package org.apache.syncope.common.lib.password;
Review Comment:
Missing license header
##########
core/am/logic/src/main/java/org/apache/syncope/core/logic/PasswordManagementLogic.java:
##########
@@ -0,0 +1,98 @@
+package org.apache.syncope.core.logic;
Review Comment:
Missing license header
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/types/PasswordManagementState.java:
##########
@@ -0,0 +1,14 @@
+package org.apache.syncope.common.lib.types;
Review Comment:
Why this enum?
##########
common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/PasswordManagementService.java:
##########
@@ -0,0 +1,104 @@
+package org.apache.syncope.common.rest.api.service;
Review Comment:
Missing license header
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/password/SyncopePasswordManagementConf.java:
##########
@@ -0,0 +1,81 @@
+package org.apache.syncope.common.lib.password;
Review Comment:
Missing license header
##########
core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/validation/PasswordManagementCheck.java:
##########
@@ -0,0 +1,22 @@
+package org.apache.syncope.core.persistence.common.validation;
Review Comment:
Missing license header
##########
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/PasswordManagementDAO.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.syncope.core.persistence.api.dao;
Review Comment:
Missing license header
##########
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/am/PasswordManagement.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.syncope.core.persistence.api.entity.am;
Review Comment:
Missing license header
##########
core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/PasswordManagementTest.java:
##########
@@ -0,0 +1,219 @@
+package org.apache.syncope.core.persistence.jpa.inner;
Review Comment:
Missing license header
##########
core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/repo/PasswordManagementRepoExt.java:
##########
@@ -0,0 +1,12 @@
+package org.apache.syncope.core.persistence.neo4j.dao.repo;
Review Comment:
Missing license header
##########
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/PasswordManagementRepoExt.java:
##########
@@ -0,0 +1,12 @@
+package org.apache.syncope.core.persistence.jpa.dao.repo;
Review Comment:
Missing license header
##########
core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/repo/PasswordManagementRepo.java:
##########
@@ -0,0 +1,9 @@
+package org.apache.syncope.core.persistence.neo4j.dao.repo;
Review Comment:
Missing license header
##########
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/am/JPAPasswordManagement.java:
##########
@@ -0,0 +1,66 @@
+package org.apache.syncope.core.persistence.jpa.entity.am;
Review Comment:
Missing license header
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/data/PasswordManagementDataBinder.java:
##########
@@ -0,0 +1,13 @@
+package org.apache.syncope.core.provisioning.api.data;
Review Comment:
Missing license header
##########
wa/starter/src/main/resources/wa.properties:
##########
@@ -139,3 +139,9 @@ management.metrics.enable.system.cpu=true
management.metrics.enable.process.cpu=true
management.metrics.enable.process.uptime=true
management.metrics.enable.process.start.time=true
+
Review Comment:
Revert these changes
##########
core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/am/Neo4JPasswordManagement.java:
##########
@@ -0,0 +1,61 @@
+package org.apache.syncope.core.persistence.neo4j.entity.am;
Review Comment:
Missing license header
##########
core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/PasswordManagementTest.java:
##########
@@ -0,0 +1,212 @@
+package org.apache.syncope.core.persistence.neo4j.inner;
Review Comment:
Missing license header
##########
wa/bootstrap/src/main/java/org/apache/syncope/wa/bootstrap/mapping/PasswordManagementPropertySourceMapper.java:
##########
@@ -0,0 +1,105 @@
+package org.apache.syncope.wa.bootstrap.mapping;
Review Comment:
Missing license header
##########
fit/core-reference/src/test/java/org/apache/syncope/fit/core/PasswordManagementITCase.java:
##########
@@ -0,0 +1,303 @@
+package org.apache.syncope.fit.core;
Review Comment:
Missing license header
##########
wa/starter/pom.xml:
##########
@@ -416,15 +438,15 @@ under the License.
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-actuator</artifactId>
+ <artifactId>spring-boot-starter-security</artifactId>
Review Comment:
revert this change
##########
wa/starter/pom.xml:
##########
@@ -416,15 +438,15 @@ under the License.
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-actuator</artifactId>
+ <artifactId>spring-boot-starter-security</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-security</artifactId>
+ <artifactId>spring-boot-starter-validation</artifactId>
Review Comment:
revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
