ilgrosso commented on code in PR #1432:
URL: https://github.com/apache/syncope/pull/1432#discussion_r3459904780
##########
core/spring/src/main/java/org/apache/syncope/core/spring/security/PasswordGenerator.java:
##########
@@ -95,9 +96,13 @@ public String getCharacters() {
}
if (!conf.getWordsNotPermitted().isEmpty()) {
- conf.getWordsNotPermitted().sort(Comparator.naturalOrder());
- rules.add(new DictionaryRule(new WordListDictionary(
- new
ArrayWordList(conf.getWordsNotPermitted().toArray(String[]::new), true)),
true));
+ WordListDictionary wld = new WordListDictionary(
Review Comment:
Case insensitive ordering shall be applied here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
