TatoniMatteo commented on code in PR #1506:
URL: https://github.com/apache/syncope/pull/1506#discussion_r3861797293
##########
client/idrepo/console/src/main/resources/META-INF/resources/css/syncopeConsole.scss:
##########
@@ -61,6 +61,9 @@ body {
border-color: $background_console_darker;
@include shadow(inset 0 1px 1px rgba(0, 0, 0, 0.075), 0 0 8px
$background_console_darker);
}
+ .input-password {
+ border-radius: 8px 0 0 8px !important;
+ }
Review Comment:
E nemmeno questo serve
##########
client/idrepo/enduser/src/main/resources/META-INF/resources/css/syncopeEnduser.css:
##########
@@ -1322,3 +1322,12 @@ h4.card-title {
background-color: #BD2130 !important;
}
+.btn.btn-eye {
+ width: 44px;
+ height: 38px;
+ border-radius: 0 8px 8px 0;
+}
+
+.input-password {
+ border-radius: 8px 0 0 8px !important;
+}
Review Comment:
Stesso discorso
##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/Login.html:
##########
@@ -56,18 +56,30 @@
<div class="container">
<div class="login-card card card-container">
- <img class="login-logo" src="ui-commons/img/logo-green.png" />
+ <img class="login-logo" src="ui-commons/img/logo-green.png"/>
<span wicket:id="feedback" role="alert"/>
<form class="form-signin" wicket:id="login">
<fieldset class="form-group">
- <input type="text" wicket:id="username" class="form-control"
- wicket:message="placeholder:username" required="required"
autofocus="autofocus" />
-
- <input type="password" wicket:id="password" class="form-control"
- wicket:message="placeholder:password" required="required" />
-
+ <input type="text" wicket:id="username" class="form-control"
+ wicket:message="placeholder:username" required="required"
autofocus="autofocus"/>
+ <div class="d-flex">
+ <input type="password" wicket:id="password" class="form-control
input-password"
+ wicket:message="placeholder:password"
required="required"/>
+ <button type="button" class="btn btn-warning btn-flat
input-group-text btn-eye" onclick="
+ var input = $(this).prev('input');
+ var type = input.attr('type');
+ var children = $(this).children();
+ if (type !== 'text') {
+ $(input).attr('type', 'text');
+ $(children).addClass('fa-eye-slash').removeClass('fa-eye');
+ } else {
+ $(input).attr('type', 'password');
+ $(children).removeClass('fa-eye-slash').addClass('fa-eye');
+ }
+ return false;"><i class="fa fa-eye"></i></button>
+ </div>
Review Comment:
Questo può essere fatto in maniera più semplice e coerente con ciò che gia
esiste in questo modo:
```
<div class="input-group d-flex">
<input type="password" class="form-control w-75"
wicket:id="password"
wicket:message="placeholder:password"
required="required"/>
<button type="button" class="btn btn-warning btn-flat
input-group-text w-25 m-0 h-100" onclick="
var input = $(this).prevAll('input');
var type = input.attr('type');
var children = $(this).children();
if (type !== 'text') {
$(input).attr('type', 'text');
$(children).addClass('fa-eye-slash').removeClass('fa-eye');
} else {
$(input).attr('type', 'password');
$(children).removeClass('fa-eye-slash').addClass('fa-eye');
}
return false;">
<i class="fa fa-eye"></i>
</button>
</div>
```
##########
client/idrepo/console/src/main/resources/META-INF/resources/css/syncopeConsole.scss:
##########
@@ -76,6 +79,13 @@ body {
background-color: $background_console_darker!important;
}
}
+
+ &.btn-eye {
+ width: 44px;
+ height: 38px;
+ border-radius: 0 8px 8px 0;
+ }
+
Review Comment:
Di conseguenza questo non serve
##########
client/idrepo/enduser/src/main/resources/org/apache/syncope/client/enduser/pages/Login.html:
##########
@@ -55,18 +55,30 @@
</div>
<div class="container">
<div class="login-card card card-container">
- <img class="login-logo" src="ui-commons/img/logo-green.png" />
+ <img class="login-logo" src="ui-commons/img/logo-green.png"/>
<span wicket:id="feedback" role="alert"/>
<form class="form-signin" wicket:id="login">
<fieldset class="form-group">
- <input type="text" wicket:id="username" class="form-control"
- wicket:message="placeholder:username" required="required"
autofocus="autofocus" />
-
- <input type="password" wicket:id="password" class="form-control"
- wicket:message="placeholder:password" required="required" />
-
+ <input type="text" wicket:id="username" class="form-control"
+ wicket:message="placeholder:username" required="required"
autofocus="autofocus"/>
+ <div class="d-flex">
+ <input type="password" wicket:id="password" class="form-control
input-password"
+ wicket:message="placeholder:password"
required="required"/>
+ <button type="button" class="btn btn-warning btn-flat
input-group-text btn-eye" onclick="
+ var input = $(this).prev('input');
+ var type = input.attr('type');
+ var children = $(this).children();
+ if (type !== 'text') {
+ $(input).attr('type', 'text');
+ $(children).addClass('fa-eye-slash').removeClass('fa-eye');
+ } else {
+ $(input).attr('type', 'password');
+ $(children).removeClass('fa-eye-slash').addClass('fa-eye');
+ }
+ return false;"><i class="fa fa-eye"></i></button>
+ </div>
Review Comment:
Stesso discorso
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
