ilgrosso commented on code in PR #1515:
URL: https://github.com/apache/syncope/pull/1515#discussion_r3903320750
##########
core/starter/src/main/java/org/apache/syncope/core/starter/SyncopeCoreApplication.java:
##########
@@ -122,14 +123,16 @@ public TaskExecutorUnloader taskExecutorUnloader(final
ListableBeanFactory beanF
@ConditionalOnMissingBean
@Bean
- public SyncopeCoreStart keymasterStart(final DomainHolder<?> domainHolder)
{
- return new SyncopeCoreStart(domainHolder);
+ public SyncopeCoreStart keymasterStart(
+ final DomainHolder<?> domainHolder,
+ final KeymasterProperties keymasterProps) {
+ return new SyncopeCoreStart(domainHolder,
keymasterProps.isEnableAutoRegistration());
}
@ConditionalOnMissingBean
@Bean
- public KeymasterStop keymasterStop(final DomainHolder<?> domainHolder) {
- return new SyncopeCoreStop(domainHolder);
+ public KeymasterStop keymasterStop(final DomainHolder<?> domainHolder,
final KeymasterProperties keymasterProps) {
+ return new SyncopeCoreStop(domainHolder, keymasterProps);
Review Comment:
Why passing only `boolean` to `SyncopeCoreStart` constructor and the whole
`KeymasterProperties` to `SyncopeCoreStop`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
