j143 edited a comment on pull request #924: URL: https://github.com/apache/systemds/pull/924#issuecomment-655714549
Hi @corepointer - Thanks a lot for working on this! 😃 Few things: 1. Shall we add the design documentation? A helpful example is https://github.com/apache/systemds/blob/7cdb51d18ee1a9d7a957f366a71d04ca818bdf91/src/main/java/org/apache/sysds/runtime/matrix/data/CudaSupportFunctions.java#L31-L58 2. Can we breakdown the whole into a few logical PRs. - The other TODO can be handled in a different PR. If this PR adds the sufficient intended functionality and is robust enough to that extent we can merge it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
