Shafaq-Siddiqi commented on a change in pull request #972:
URL: https://github.com/apache/systemds/pull/972#discussion_r455899136
##########
File path: src/test/scripts/functions/caching/BufferpoolLeak.dml
##########
@@ -22,7 +22,7 @@
X = rand(rows=$1, cols=$2, min=1, max=10);
for(i in 1:500) {
#print("executed iteration "+i)
- [m1,m2] = mice(as.frame(X), matrix(0,1,ncol(X)),3,3, FALSE)
+ [m1,m2] = mice(X), matrix(0,1,ncol(X)), 3, FALSE)
Review comment:
> It seems like the parenthesis is incorrect here.
> Does this not crash the system?
I fixed the call, surprisingly it was not crashing the test on git. After
fixing the call now the cache is leaning and BufferpoolleakTest is failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
