Shafaq-Siddiqi commented on a change in pull request #976: URL: https://github.com/apache/systemds/pull/976#discussion_r455925399
########## File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinGMMTest.java ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sysds.test.functions.builtin; + +import org.apache.sysds.common.Types; +import org.apache.sysds.hops.OptimizerUtils; +import org.apache.sysds.lops.LopProperties; +import org.apache.sysds.runtime.matrix.data.MatrixValue; +import org.apache.sysds.test.AutomatedTestBase; +import org.apache.sysds.test.TestConfiguration; +import org.apache.sysds.test.TestUtils; +import org.junit.Test; + +import java.util.HashMap; + +public class BuiltinGMMTest extends AutomatedTestBase { + private final static String TEST_NAME = "GMM"; + private final static String TEST_DIR = "functions/builtin/"; + private static final String TEST_CLASS_DIR = TEST_DIR + BuiltinGMMTest.class.getSimpleName() + "/"; + + private final static double eps = 1; + private final static double tol = 1e-3; + private final static int rows = 100; + private final static double spDense = 0.99; + private final static String DATASET = SCRIPT_DIR + "functions/transform/input/iris/iris.csv"; + + @Override public void setUp() { + addTestConfiguration(TEST_NAME, new TestConfiguration(TEST_CLASS_DIR, TEST_NAME, new String[] {"B"})); + } + + @Test public void testGMMM1() { runGMMTest(3, "VVV", "random", 100, 0.000001, true, LopProperties.ExecType.CP); } Review comment: > Hi @Shafaq-Siddiqi, > > I think this looks awesome, 🥇 > Unfortunately I'm not that well versed in the internals of GMM so i hope the math is in order, but looking at the internal operations i really look forward to try it out on the compressed representation! > > I have some minor comments and questions you that would be great if you could answer! > > On the less important side, the script `gmm.dml` as it is now does not follow what i thought to be the coding guidelines. > > 1. Variable inputs names should be CamelCase. > 2. Indentation should be tabs not double space. > > I'm fine if you don't want to change it, but i really value if we could aim for some consistency between our scripts. I can also change my formatting to the settings you use. > > I also can't help but notice that there are no doc entry added for this new operation, that would also be great! If I remember correctly, we agreed on two spaces in dml. I will confirm and then will change accordingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
