Baunsgaard commented on a change in pull request #984:
URL: https://github.com/apache/systemds/pull/984#discussion_r458594443
##########
File path:
src/main/java/org/apache/sysds/hops/rewrite/RewriteConstantFolding.java
##########
@@ -98,13 +98,7 @@ private Hop rConstantFoldingExpression( Hop root ) {
if( root.getDataType() == DataType.SCALAR //scalar output
&& ( isApplicableBinaryOp(root) ||
isApplicableUnaryOp(root) ) )
{
- //core constant folding via runtime instructions
- try {
- literal = evalScalarOperation(root);
- }
- catch(Exception ex) {
- LOG.error("Failed to execute constant folding
instructions. No abort.", ex);
- }
+ literal = evalScalarOperation(root);
Review comment:
The main issue is that previously it did not fail. because the error was
caught and not handled, while the program would crash at some arbitrary place
afterwards (or not at all). When the system crashed the exception had no
reference to this place unless your logging settings were set to ERROR level
and in that case you had to still sift through the logging messages to find the
exception. that was the actual root course. (to much work for a single
exception)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
