mboehm7 commented on pull request #1020: URL: https://github.com/apache/systemds/pull/1020#issuecomment-673596743
LGTM - thanks for the addition @kev-inn. I only changed the name to `colnames(X)` for consistency with the existing R function. Similarly, I change `typeOf` to `typeof`, and removed some unnecessary imports. Down the road we might actually move all these frame meta data operations to unary aggregates as they fit the schema of column aggregates. Regarding documentation, I personally would prefer documentation in a batches of builtin functions (one PR per batch), but there are no general guidelines yet (we want to modify the contributing guidelines with @j143 anyway). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
