mboehm7 commented on pull request #1027: URL: https://github.com/apache/systemds/pull/1027#issuecomment-677900762
LGTM - thanks for the patch @kev-inn. Overall this is nice, I just made some minor modifications: (1) fixed the export in `CacheableData` which did not handle federated objects (it might have worked due to previous transfer to the coordinator by chance), (2) fixed the removed replace handling in parsing of parameterized builtin instructions, (3) generalized the improved exception handling from UDFs to instruction execution and clear commands, and (4) fixed a javadoc issue I introduced in a previous commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
