mboehm7 commented on pull request #1034: URL: https://github.com/apache/systemds/pull/1034#issuecomment-679250773
LGTM - thanks for this great addition. I made some moderate changes though: (1) support for real lambda expressions with arbitrary bound variables, (2) support for multi-column frames, (3) renamed from dmlMap to map, (4) added the binary.frame test package to our github tests, (5) generated subsclasses of FrameMapFunction to avoid java reflection for performance, and (6) some minor formatting changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
