mboehm7 commented on a change in pull request #1054:
URL: https://github.com/apache/systemds/pull/1054#discussion_r487525755
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorkerHandler.java
##########
@@ -155,7 +155,7 @@ private FederatedResponse executeCommand(FederatedRequest
request) {
catch (Exception ex) {
return new FederatedResponse(ResponseType.ERROR,
new FederatedWorkerHandlerException("Exception
of type "
- + ex.getClass() + " thrown when processing
request", ex));
+ + ex.getClass() + " thrown when processing
request"));
Review comment:
Could you elaborate why we send the exception for privacy exceptions but
NOT for all other exceptions? Shouldn't it be the other way around? In that
spirit I would also add the catch clause for PrivacyExceptions in the other
places, while in general send the exceptions to allow for debugging at the
coordinator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
