mboehm7 commented on pull request #1070: URL: https://github.com/apache/systemds/pull/1070#issuecomment-706555293
LGTM - thanks for the new builtin functions @gabrielaozegovic. This completes the AMLS project. Just for the record, during the merge, I made the following modifications: (1) added an als function, (2) renamed als_cg and als_ds to alsCG and alsDS (for consistency with the lm builtin functions), (3) merged the tests, (4) fix the test formatting (tabs over spaces in java code), (5) removed stats/explain from tests, (6) fixed the function input arguments (e.g., unnecessary format, reg for alsDS) and comments, (7) fixed the output of alsDS (the reason why it was failing was that the output R was not transposed because it was written to Rt instead of R), and (8) made some minor cleanups within the algorithms. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
