+1
Thanks,
Shafaq Siddiqi
On 10/10/2020 2:26 PM, Baunsgaard, Sebastian wrote:
+1
but i have a few points that are not critical, but i leave it up to the release
manager to decide, if we want more release candidates:
1) We still have a few SystemML, references left in our scripts/nn/examples in
the release.
grep -rnw . -e 'systemml'
./scripts/nn/examples/Example - Neural Collaborative Filtering.ipynb:172: "#
HADOOP_HOME= /Users/patrick/Uni Offline/Architectures of Machine Learning Systems
(AMLS)/systemml/target/lib/hadoop\n",
./scripts/nn/examples/README.md:54:* To run the examples, please first download and unzip
the project via GitHub using the "Clone or download" button on the [homepage of
the project](https://github.com/dusenberrymw/systemml-nn), *or* via the following
commands:
./scripts/nn/examples/README.md:57: git clone
https://github.com/dusenberrymw/systemml-nn.git
./scripts/nn/examples/README.md:60:* Then, move into the `systemml-nn` folder
via:
./scripts/nn/examples/README.md:62: cd systemml-nn
./scripts/nn/examples/README.md:73:* **Notebooks**: To run the notebook
examples, please install the SystemDS Python package with `pip install
systemds`, and then startup Jupyter in the following manner from this directory
(or for more information, please see [this great blog
post](http://spark.tc/0-to-life-changing-application-with-apache-systemml/)):
2) The /bin/systemds, does not parse on our logging nor our settings file when
executing on spark, forcing users to manually make the spark-submit instruction
if such customization is desired.
3) Our distribution contain python examples and notebooks in
/scripts/nn/examples that describe how to use the previous python, not our
current. I would remove them from our distribution.
4) Again /scripts/nn/examples contains code to download MNIST from a
questionable source (https://pjreddie.com) with very slow download times.
5) /scripts/nn/tests should not be included in a release
6) /scripts/util we should consider removing some of the scripts
7) most /scripts/algorithms/ contain examples on how to execute using Hadoop,
which is no longer supported in the system.
8) I think that /scripts/aws does not belong in our scripts folder, but should
rather be pages in documentation.
9) I think all obsolete folders should not be included in release.
10) I think we can remove avro-ipc-1.7.7-tests.jar from our lib.
11) A previously mentioned point we duplicate our jar two places, we should fix
it to only have one.
12) Why do we have a systemds-2.0.0-extra.jar ? if not needed then i think that
should be removed as
best regards
Sebastian
________________________________
From: arnab phani <[email protected]>
Sent: Saturday, October 10, 2020 1:37:48 AM
To: [email protected]
Subject: Re: [VOTE] Apache SystemDS 2.0.0 (RC3)
+1
Thanks and regards,
Arnab..
On Fri, Oct 9, 2020, 06:05 Janardhan <[email protected]> wrote:
+1
Thank you,
Janardhan
On Fri, Oct 9, 2020 at 1:33 AM Matthias Boehm <[email protected]> wrote:
+1, thanks everybody for the effort getting this RC ready.
Regards,
Matthias
On 10/7/2020 11:54 PM, arnab phani wrote:
Please vote on releasing the following candidate as Apache SystemDS
version
2.0.0
The vote is open for at least 72 hours and passes if a majority of at
least
3 +1 PMC votes are cast.
[ ] +1 Release this package as Apache SystemDS 2.0.0
[ ] -1 Do not release this package because ...
To learn more about Apache SystemDS, please see
http://systemds.apache.org/
The tag to be voted on is v2.0.0-rc3
(aab2e08f73171b8abef363b22107ab6c2f90aedf ):
https://github.com/apache/systemds/tree/v2.0.0-rc3
The release artifacts can be found at:
https://dist.apache.org/repos/dist/dev/systemds/2.0.0-rc3/
The maven release artifacts, including signatures, digests, etc. can be
found at:
https://repository.apache.org/content/repositories/orgapachesystemds-1009/org/apache/systemds/systemds/2.0.0/
===========================
== Apache Release policy ==
===========================
http://www.apache.org/legal/release-policy.html
=======================================
== How can I help test this release? ==
=======================================
If you are a SystemDS user, you can help us test this release by taking
an
existing Algorithm or workload and running on this release candidate,
then
reporting any regressions.
================================================
== What justifies a -1 vote for this release? ==
================================================
-1 votes should only occur for significant stop-ship bugs or legal
related
issues (e.g. wrong license, missing header files, etc). Minor bugs or
regressions should not block this release.
Regards,
Arnab..
