Baunsgaard commented on a change in pull request #1047:
URL: https://github.com/apache/systemds/pull/1047#discussion_r519916551
##########
File path: src/test/java/org/apache/sysds/test/AutomatedTestBase.java
##########
@@ -1380,80 +1386,116 @@ public static int getRandomAvailablePort() {
return availableSocket.getLocalPort();
}
catch(IOException e) {
- // If no port was found just use 9999
+ // If no port was found just use 9990
return 9990;
}
Review comment:
i think i did this, because i experienced weird behavior in cases where
i searched for a random available port recursively, and i did not want a
potential infinite loop in our tests startup.
But i do agree that searching for a valid port would be better, than just
returning this default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
