Baunsgaard commented on pull request #1106:
URL: https://github.com/apache/systemds/pull/1106#issuecomment-727640947


   > ok, increasing the generality of implementations is a good idea. In that 
case I would recommend to not probe for type FULL in individual operations, but 
put methods isRowPartitioned (ROW or FULL), isColumnPartitions (COL or FULL) 
into the enum type and then probe these methods from the instructions.
   
   Ah good idea, I forgot java can do this with Enums


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to