mboehm7 commented on pull request #1123: URL: https://github.com/apache/systemds/pull/1123#issuecomment-743766561
ad 1) besides the changed overall behavior, the comment referred to `replace(target=ScaleFactor, pattern=NaN, replacement=1e-16);`, which would need to replace zero as this happens before the division. ad 2/3) for local experiments this is fine, but for the hierarchy of builtin functions, we should aim for simple and stable APIs and find other ways to automatically remove redundancy (e.g., by lineage-based reuse). Passing all these intermediates around would quickly become really messy and confusing for both users and developers. Which PCA predict do you refer to - is there already a builtin function for it? Generally, please don't rewrite the builtin functions just to make them more amenable for compressed operations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
