mboehm7 commented on pull request #1132: URL: https://github.com/apache/systemds/pull/1132#issuecomment-748529081
LGTM - thanks for the initiative and the patch @Shafaq-Siddiqi. This is a great addition. I now fixed the spark instructions (seed generation, block sizes) and a few other issues (matrix redirect to reshape, warnings, formatting, frame recompilation, tests), as well as started refactoring `DataExpression` to make it more maintainable. In a follow-up PR (whenever you get a chance), please fix the hard-coded seed though. This requires consistent seed generation for 1k blocks on the CP side too so both CP and Spark generate exactly the same results. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
