mboehm7 commented on pull request #1131: URL: https://github.com/apache/systemds/pull/1131#issuecomment-748652239
LGTM - thanks for the extensions @tobiasrieger. This patch is a good start for experiments on these balancing and data partitioning techniques. During the merge, I only made a few tweaks here and there: added serial IDs to serializable classes, renamed `getFRangeFDataMap` to `getMap`, capitalized all class names, replaced the prints of non-implemented errors with `NotImplementedException`s, replaced the progress printing with log info messages (so they can be disabled if needed), reconfigured the matrix multiplies for shuffling, replication, and sampling to the available vcores (instead of 1), changed the wait in the federated paramserv test to the global fed-worker wait configuration, and made some minor formatting changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
