mboehm7 commented on pull request #1138: URL: https://github.com/apache/systemds/pull/1138#issuecomment-753909341
LGTM - thanks for the design doc @FraCorti. I moved it now to `scripts/staging`, added the license header, removed the author name (apart from the git history, we're not using author tags), and added two notes. Specifically, please try to avoid hard dependencies to LLVM by using a similar integration like our native BLAS libraries [1]. You can compile a proxy shared library, users specify the location of LLVM libraries via `-Djava.library.path`, and we try to dynamically load this library during runtime and fallback to java if unsuccessful. In maven, you can specify the scope of llvm as test. [1] https://github.com/apache/systemds/blob/master/src/main/java/org/apache/sysds/utils/NativeHelper.java ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
