Baunsgaard commented on pull request #1146: URL: https://github.com/apache/systemds/pull/1146#issuecomment-757271140
LGTM, But i can see that it is a struggle to implement some of the things needed for string processing in DML. Especially the "generate ascii matrix" part looks painfully inefficient. Note that this is not a problem from your side, but a limitation in the system currently, and you have appropriately added a TODO. In the future we need to add internal functions for the system maybe Set or Map data structures in DML to enable better processing for these kinds of problems. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
