Baunsgaard commented on pull request #1152: URL: https://github.com/apache/systemds/pull/1152#issuecomment-760736945
to respond to the questions 1. The shape requirements in the python script is only there to allow quick termination of the program, from python, therefore not requireing the dml script to crash. We can simply remove these. 2. If you look at multilogreg then you can see an example of 3 return values. The PCA have changed recently to return more values and apparently this did not break the PCA for python (which it should have). The multiReturn is currently not a good solution in general, and could benefit from some other handling like for instance a dedicated operation node type. I also quickly went through the code and it looks nice, will come back to it with comments later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
