mboehm7 commented on pull request #1142:
URL: https://github.com/apache/systemds/pull/1142#issuecomment-761696065
LGTM, thanks for the patch @OlgaOvcharenko. As it turned out the remaining
issue was still a local issue in federated indexing. In detail, the original CP
instruction was:
`
CP°rightIndex°X·MATRIX·FP64°1·SCALAR·INT64·true°10000·SCALAR·INT64·true°i·SCALAR·INT64·false°i·SCALAR·INT64·false°_mVar314·MATRIX·FP64
`
When acquiring the index range, we obtain the value of `i` from the symbol
table, but during the replacement we tried to replace the variable names only.
By simply constructing new scalar literals directly we now handle this
correctly. Additionally, I only removed some unnecessary imports (warnings).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
