mboehm7 commented on pull request #1108: URL: https://github.com/apache/systemds/pull/1108#issuecomment-766195637
LGTM - thanks for the patch @Shafaq-Siddiqi. Generally this looks very good. I just renamed the new builtin to gmmPredict for consistency, changed the formatting a bit, added the missing reset of rewrite flags in the test, and disabled the spark tests (as forced spark mode at algorithm level is a bit too much here). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
