mboehm7 commented on pull request #1172: URL: https://github.com/apache/systemds/pull/1172#issuecomment-782765095
LGTM - this is a great addition. Thanks @ywcb00 @ukw01 @Metka Batič. During the merge I did a few cleanups: (1) removed warnings (imports, unused variables), (2) fixed the script formatting (mix of 1/2/3/4 space indentation), (3) fixed the R script (removed R package installation, moved to `installDependencies.R`, and ignored test for now as we have to update the docker image first), and (4) vectorized `calculateDistance` function in knnbf. Furthermore, I also folded a minor change of our github action workflows into this patch (to balance the test suites a bit). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
