kpretterhofer commented on pull request #1153:
URL: https://github.com/apache/systemds/pull/1153#issuecomment-790654858


   > Hi,
   > Thank you for your contribution. Could you please add a test to predict 
some data using the classifier. We have iris dataset inside 
function/transform/input directory. You can write a test to predict the class 
labels for iris.
   
   Thanks for the feedback! 
   Probably just one follow up question: Should I only write a test for 
predictions, or should I also implement a builtin prediction function? (The 
current implementation only computes and returns the parameters needed for 
prediction, thats why I am asking)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to