ywcb00 opened a new pull request #1214: URL: https://github.com/apache/systemds/pull/1214
Hi, This is a PR for adding federated code generation for cellwise templates, and the respective tests. Inside the test class, there are two datasets outcommented. The first one fails because we are fusing the sequence operation into the Spoof class without adjusting the grix parameter of the genexec call to the individual offsets of the federated matrix paritions. The second test fails because it doesn't create a federated instruction of the spoof operator (due to indexing, where the matrix gets copied to the coordinator). I've implemented a fix for adjusting the grix to correctly include sequences with federated operations in a previous commit (43e9ff2), but it isn't a nice fix (adding a suffix to the instruction string whenever it is a federated spoof operation) so I removed it. Maybe we can exclude the sequence operation from code generation? Thanks for review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
