mboehm7 commented on pull request #1216: URL: https://github.com/apache/systemds/pull/1216#issuecomment-813418744
LGTM - awesome, thanks @OlgaOvcharenko for the quick turn around. I made some minor changes and left a few TODOs, mostly for performance. When increasing the number of rows in the tests, cumprod and cumsumprod, where failing which is likely due to a remaining issue of how we handle the offsets. I would recommend to leave it as is for now (having cumsum/cummin/cummax is already valuable) and coming back to it once we have the federated left indexing, which would allow for easier handling of these offsets without custom UDF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
