ywcb00 commented on a change in pull request #1218:
URL: https://github.com/apache/systemds/pull/1218#discussion_r613281546
##########
File path:
src/test/java/org/apache/sysds/test/functions/federated/codegen/FederatedCellwiseTmplTest.java
##########
@@ -147,8 +145,8 @@ private void testFederatedCodegen(ExecMode exec_mode) {
// generate dataset
// matrix handled by two federated workers
- double[][] X1 = getRandomMatrix(fed_rows, fed_cols, 0, 1,
sparsity, 3);
- double[][] X2 = getRandomMatrix(fed_rows, fed_cols, 0, 1,
sparsity, 7);
+ double[][] X1 = getRandomMatrix(fed_rows, fed_cols, 0, 1, 1, 3);
+ double[][] X2 = getRandomMatrix(fed_rows, fed_cols, 0, 1, 1, 7);
Review comment:
That makes sense for large matrices, but since we also have matrices
containing only a few elements I'm afraid of falsifying the test results by
changing it. (worst case: all elements of matrix X are 0)
I'm not sure if such a case can happen, can it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
