Baunsgaard commented on pull request #1225: URL: https://github.com/apache/systemds/pull/1225#issuecomment-820204693
Hi @j143 I both like and dislike the idea. on one hand it makes sense to have a one place build all, but I'm worried about 2 things. 1. Increased package time... (i package the project 10 - 100 times a day) so if it increase this i would not have this change 2. Confusion about what is inside our builds, since with this we have to manage the python API in our build of the system, rather than only in connection with python. If you really really like the feature, and intend to use it. I would make it execute under a specific -D like PythonAPI, but then again it does not hook up into anything so there is more work needed if we want to pursue this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
