sebwrede commented on pull request #1184: URL: https://github.com/apache/systemds/pull/1184#issuecomment-820616858
I think the test coverage is improving, but there are still some gaps that would be nice to cover. It is not because I believe there is anything wrong with the parts that are not covered, but I think it is important to cover so that we have the tests later on when we make changes to the federated instructions. For instance, as far as I can see, the `isFedOutput` method is never called. This is a significant part of the code which is never activated. Besides that, I think this PR looks good. The failing test is caused by a sparkDriver error from the master branch, so this PR seems ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
