TMaddox commented on a change in pull request #1234: URL: https://github.com/apache/systemds/pull/1234#discussion_r619850306
########## File path: src/main/python/systemds/matrix/matrix.py ########## @@ -25,15 +25,15 @@ import numpy as np from py4j.java_gateway import JavaObject, JVMView from systemds.context import SystemDSContext -from systemds.operator import OperationNode +from systemds.operator import OperationNode2 from systemds.utils.consts import VALID_INPUT_TYPES from systemds.utils.converters import numpy_to_matrix_block # TODO maybe instead of having a new class we could have a function `matrix` instead, adding behavior to -# `OperationNode` would be necessary +# `OperationNode2` would be necessary -class Matrix(OperationNode): +class Matrix(OperationNode2): Review comment: The matrix class isn't changed at all, I just need it to inherit from the temporary OperationNode class, which is called OperationNode2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org