TMaddox commented on pull request #1234: URL: https://github.com/apache/systemds/pull/1234#issuecomment-827012889
I see, it seems like I misunderstood the assignment and as I haven't got the insight in the lib like you do so I am afraid I can't comment/discuss that with you, but what you say definitely makes sense. Besides that I would like to respond to one comment of yours: > One of the reasons why this is important to separate, is because many operations supported directly on a OperationNode is not valid on a "MultiNode", like for instance min. > Rather than having to introduce an if else inside the min function (if we chose the universal approach) trowing an invalid exception, i would prefer not having that if else. My approach to solve this via the universal node approach was, that the first output will become the standard, meaning if not specified the first output will be used for all operations. So if I call the operation min on a multi node it returns the min of the first output node. A downside of this proposed solution is that it probably won't be as strait forward for a user as your approach in my opinion, as the user needs to know that the first output node is the standard output. I will change it so there is a separate MultiNode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
