Baunsgaard commented on pull request #1275: URL: https://github.com/apache/systemds/pull/1275#issuecomment-843034161
> > Hello and thank you for your effort in this PR! > > In general I agree with Sebastian, it looks good, but if I may chime in with additional questions: > > Why is Pillow used? I'm sure there are image manipulation libraries for R and Java that could be used. > > I guess the use of Pillow is the reason for the additional resource files and the methods in TestUtils? That (and the mentioned precision issues) could be avoided by using an R or Java library for comparison. > > jm2c ;-) > > Mark > > I use Pillow as a reference because one of the reasons I added the builtins is to reproduce the results of AutoAugment (https://arxiv.org/abs/1805.09501) and they use Pillow. I don't think using Pillow is an issues, since it is only used in tests and not actually added to the system, since all the results seems to be added as references. Therefore nothing will not be included as a resource in the system. That said it would be better with the actual expected results (calculated and verified not using our system), than results where we have to consider rounding errors from floating point to uint. but i consider this out of scope of this project, since the methods are tested and verified sufficiently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
