ywcb00 opened a new pull request #1287:
URL: https://github.com/apache/systemds/pull/1287


   Hi,
   This PR adds support for federated **spoof** instructions with multiple 
**aligned** federated matrices.
   It was necessary to create an additional _isAligned()_ method in order to 
support partial alignments.
   The _SpoofFEDInstruction_ needed some rewrites to not change the order of 
inputs, because we need the correct order to distinguish between the side 
inputs _U_ and _V_ for the outerproduct template.
   I added comparision of the end dimensions of federated ranges in 
_FederatedRange.compareTo()_, hope this does not create any problems with other 
functionalities.
   I also added the method _heavyHittersContains(Sub)String()_ with an 
additional parameter _minCallCount_ which allows to check for a minimum number 
of calls for a specific heavy hitter.
   There are a lot of outcommented tests because I tried to bundle multiple 
testcases into a single test to reduce the time for test preparation.
   
   Thanks for review :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to