fathollahzadeh commented on a change in pull request #1299:
URL: https://github.com/apache/systemds/pull/1299#discussion_r648362275
##########
File path: src/main/java/org/apache/sysds/parser/DataExpression.java
##########
@@ -112,6 +112,9 @@
public static final String DELIM_NA_STRING_SEP = "\u00b7";
// Parameter names relevant to reading/writing delimited index/libsvmv
files
public static final String LIBSVM_INDEX_DELIM = "indSep";
+
+ // Parameter names relevant to reading/writing dataset name/hdf5 files
+ public static final String HDF5_DATASET_NAME = "dataset";
Review comment:
The HDF5 format can contain multiple datasets and the datasets can
distinguish by name/groups. So, it required the dataset name when we have
multiple datasets inside of the HDF5 file. But for the single dataset inside of
a file, it is unnecessary. Again on the write side, I already mentioned we are
supporting a single dataset, it is unnecessary for us too. Maybe it is
important for the end-user!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
