Baunsgaard commented on pull request #1303:
URL: https://github.com/apache/systemds/pull/1303#issuecomment-858550427


   > Well, if you cannot extract the information at compile time and cannot 
build the tree during runtime, then I agree that the best solution is to put 
the information somewhere that is not in the instruction string, like you have 
done in this PR.
   > 
   > Another comment: If you change the `_cops` field, `addCompressedOp`, and 
`getCompressOps` to something like `_highlightedOps`, `addHighlightedOp`, and 
`getHighlightedOps` then the class would already be generalized enough to be 
used for other workload tree representations, such as the one I need for the 
federated executions.
   
   should be changed now, But it is not enough to make it applicable to 
federated, for that you need to define 
   
   1. A new IPA
   2. A new Analyzer
   
   also if you decide to do so, we need to move this workload package to some 
more general location. perhaps a new package called workload in the runtime 
folder?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to