atefeh-asayesh commented on pull request #1336: URL: https://github.com/apache/systemds/pull/1336#issuecomment-886262588
Thanks for the comments. The reason that both parameters are considered in one Pull Request was because both parameters are optionally applied in similar tests and files. A separate test function is also considered to check the nBatches test in some test functions. About the gradient accumulation I want to discuss about it in meeting. Removal of PS_MODELS will be done. computeBatch always pushed the gradients but computeBatch_Avg push the models. in the federated control thread (per worker) in both computeWithBatchUpdates and also computeWithEpochUpdates, modelAvg condition is considered. Moreover, I will try to simplify the core code as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
