mboehm7 commented on pull request #1353: URL: https://github.com/apache/systemds/pull/1353#issuecomment-888675789
LGTM - thanks Max and Julian for the initial version of this deepWalk builtin function, which is a good start for future extensions. During the merge, I made the following changes: * Vectorized the code for `createBinaryTreeMatrix`, `computeGradients`, and the computation of negative gradient for Phi update (these changes improved performance of the CP test from 74s to 49s in my environment) * Added the missing ASF license to the Java test class, and fixed its formatting (tabs over spaces for Java code) * Removed unnecessary imports (sourcing) of builtin functions * Fix some minor formatting issues in the deepWalk builtin function (2 space indentation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
