DavidSandruTU commented on a change in pull request #1357: URL: https://github.com/apache/systemds/pull/1357#discussion_r680547268
########## File path: scripts/perftest/README.md ########## @@ -28,10 +28,16 @@ There are a few prerequisites: - Setup OpenBlas: <https://github.com/xianyi/OpenBLAS/wiki/Precompiled-installation-packages> - Install Perf stat: <https://linoxide.com/linux-how-to/install-perf-tool-centos-ubuntu/> -NOTE THE SCRIPT HAS TO BE RUN FROM THE ROOT OF THE REPOSITORY. +NOTE THE SCRIPT HAS TO BE RUN FROM THE PERFTEST FOLDER. +Examples: ```bash -./scripts/perftest/runAll.sh +./runAll.sh + +./runAll.sh perftestTemp MR Review comment: Lets say I understood it correctly and "./runAll.sh ./sparkDML.sh" is a valid call, then the problem here is that the sparkDML.sh script needs double dashes for its flag arguments I believe. Should I do a substring check if the argument contains "sparkDML.sh" and then prepend an additional dash to the flags? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
