mboehm7 commented on pull request #1389: URL: https://github.com/apache/systemds/pull/1389#issuecomment-917146513
Thanks for starting the work on exposing the frame replace and making it more robust. For use at script level, please introduce copy on write semantics with shallow copy of unmodified columns. Right now the implementation does a shallow copy for all columns and then modifies these columns in place, which changes both the output and input and thus, yields incorrect results (e.g., B=replace(A) also modifies A). Additional, please double check if the `UtilFunctions.objectToObject` and similar functions could be used to avoid conversions to string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
