fathollahzadeh commented on pull request #1369:
URL: https://github.com/apache/systemds/pull/1369#issuecomment-919347735
> Thanks @fathollahzadeh - that's a good first step and we can bring it in
as experimental after some additional cleanups (dependencies, imports). As next
steps we should run some experiments for better understanding the runtime
breakdown, and then generalize the hard-coded readers to code-generated reads
that utilize sub-templates for key concepts.
Thanks @mboehm7 for the first review and your supports. The new updates are
supporting auto-generate readers for Matrix and Frame. In matrix readers, we
are supporting general, symmetric (upper, lower triangular), and
skew-symmetric. At this PR we do not support pattern matching. For Frame
readers, we are supporting three value types (STRING, Numeric, and BOOLEAN).
Unknown value types in Frame are our future work.
For the test side, we don't have any DML scripts. We are calling pure java
public methods for generating readers. The new DML script is also our future
work.
Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
