mboehm7 commented on pull request #1363: URL: https://github.com/apache/systemds/pull/1363#issuecomment-922377164
LGTM - thanks for this major extension @OlgaOvcharenko. During the merge, I fixed the merge conflicts (in the future please rebase if possible), fixed the warnings and a few minor issues. As a next step, we should think about consolidating the now replicated federated matrix multiplication (in fed mapmm). Maybe we get away with dedicated instruction string handling and otherwise can channel everything through a single matrix multiplication (because there are of course many more spark matrix multiplications such as cpmm and rmm). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
