mtfs20 commented on a change in pull request #1406:
URL: https://github.com/apache/systemds/pull/1406#discussion_r727338366
##########
File path: src/main/java/org/apache/sysds/lops/Unary.java
##########
@@ -122,7 +122,12 @@ private String getOpcode() {
}
public static boolean isMultiThreadedOp(OpOp1 op) {
- return op==OpOp1.CUMSUM
+ if(op == OpOp1.INVERSE || op == OpOp1.CHOLESKY || op ==
OpOp1.DETECTSCHEMA)
Review comment:
Done.
##########
File path:
src/main/java/org/apache/sysds/runtime/instructions/cp/UnaryCPInstruction.java
##########
@@ -61,8 +63,9 @@ public static UnaryCPInstruction parseInstruction ( String
str ) {
in.split(parts[1]);
out.split(parts[2]);
func = Builtin.getBuiltinFnObject(opcode);
-
- if( Arrays.asList(new
String[]{"ucumk+","ucum*","ucumk+*","ucummin","ucummax","exp","log","sigmoid"}).contains(opcode)
){
+ Types.OpOp1 op_type =
Types.OpOp1.valueOfByOpcode(opcode);
+ //if( Arrays.asList(new
String[]{"ucumk+","ucum*","ucumk+*","ucummin","ucummax","exp","log","sigmoid","round"}).contains(opcode)
)
+ if( Unary.isMultiThreadedOp(op_type)){
Review comment:
Done.
##########
File path: src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixAgg.java
##########
@@ -336,7 +338,7 @@ public static MatrixBlock
cumaggregateUnaryMatrix(MatrixBlock in, MatrixBlock ou
AggregateUnaryOperator uaop =
InstructionUtils.parseBasicCumulativeAggregateUnaryOperator(uop);
//fall back to sequential if necessary or agg not supported
- if( k <= 1 || (long)in.rlen*in.clen < PAR_NUMCELL_THRESHOLD1
|| in.rlen <= k
+ if( k <= 1 || (long)in.rlen*in.clen < PAR_NUMCELL_THRESHOLD1 ||
in.rlen <= k
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
